Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: remove some client global vars #1655

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

remove pkg/client and some global vars.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

remove pkg/client and some global vars.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Aug 15, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Aug 15, 2023
Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rambohe-ch Please fix ci error.

Signed-off-by: rambohe-ch <linbo.hlb@alibaba-inc.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1655 (243d7dc) into master (96c32a7) will increase coverage by 0.22%.
The diff coverage is 0.00%.

❗ Current head 243d7dc differs from pull request most recent head 254c36a. Consider uploading reports for the commit 254c36a to get more accurate results

@@            Coverage Diff             @@
##           master    #1655      +/-   ##
==========================================
+ Coverage   52.24%   52.47%   +0.22%     
==========================================
  Files         155      155              
  Lines       17657    17536     -121     
==========================================
- Hits         9225     9202      -23     
+ Misses       7605     7509      -96     
+ Partials      827      825       -2     
Flag Coverage Δ
unittests 52.47% <0.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../daemonpodupdater/daemon_pod_updater_controller.go 29.80% <ø> (+0.29%) ⬆️
pkg/controller/raven/gateway/gateway_controller.go 22.69% <0.00%> (ø)
...ntroller/yurtappdaemon/yurtappdaemon_controller.go 19.47% <0.00%> (ø)
pkg/controller/yurtappset/yurtappset_controller.go 47.08% <0.00%> (+0.41%) ⬆️
...ntroller/yurtstaticset/yurtstaticset_controller.go 42.02% <0.00%> (-0.13%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Aug 17, 2023
@openyurt-bot openyurt-bot merged commit 4bd6414 into openyurtio:master Aug 17, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants