Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support yurtadm config command #1709

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Sep 19, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1536

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1536

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YTGhost
To complete the pull request process, please assign fei-guo
You can assign the PR to them by writing /assign @fei-guo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1709 (df23e8c) into master (f782021) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1709      +/-   ##
==========================================
- Coverage   51.64%   51.61%   -0.04%     
==========================================
  Files         168      169       +1     
  Lines       20063    20073      +10     
==========================================
- Hits        10362    10360       -2     
- Misses       8716     8727      +11     
- Partials      985      986       +1     
Flag Coverage Δ
unittests 51.61% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/yurtadm/util/cmdutil.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@YTGhost
Copy link
Member Author

YTGhost commented Sep 19, 2023

@rambohe-ch PTAL

Signed-off-by: Liang Deng <283304489@qq.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.2% 5.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@YTGhost
Copy link
Member Author

YTGhost commented Sep 20, 2023

@rambohe-ch PTAL

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Oct 8, 2023
@rambohe-ch rambohe-ch merged commit cdb632a into openyurtio:master Oct 8, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Support yurtadm config command
3 participants