-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nodelifecycle controller #1746
add nodelifecycle controller #1746
Conversation
Hi rambohe-ch, I review this code for a long time, it seems that have no problems, but for insurance reasons, shall we organize a code review meeting, from you to show us the detail of the code, it can improve the quality of code. |
d7e5142
to
c769404
Compare
Codecov Report
@@ Coverage Diff @@
## master #1746 +/- ##
==========================================
+ Coverage 50.80% 52.15% +1.35%
==========================================
Files 165 172 +7
Lines 19258 20876 +1618
==========================================
+ Hits 9784 10888 +1104
- Misses 8555 9025 +470
- Partials 919 963 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c769404
to
4cf3e47
Compare
4cf3e47
to
aeab414
Compare
@JameKeal Thanks for your suggestion. I think maybe it's a good idea to introduce this pull request in a community meeting. |
aeab414
to
456c897
Compare
2. don't mark pods not ready when node has pod binding annotation
456c897
to
83263d4
Compare
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, YTGhost The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@JameKeal: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #1713 |
Should we disable node lifecycle controller in kube-controller-manager in OpenYurt v1.4? |
@crazytaxii yes, we need to disable the nodelifecycle controller in kube-controller-manager component. and the tip has been added in the OpenYurt setup tutorial. the link is here: https://openyurt.io/docs/installation/manually-setup#2-prerequisites-for-installing-the-openyurt-control-plane
|
based on our test, seems there is no need to remove the node lifecycle controller from kube-controller-manager. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
As we discussed in the community meeting, nodelifecycle controller will be managed in yurt-manager controller and disabled in kube-controller-manager in order to manage pods eviction easily.
and the following two features are included in this pr:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note