Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable the iptables setting of yurthub component by default #1770

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

disable iptables setting of Yurthub component by default, and we will remove iptables setting in the future. this means we will remove parameter --enable-iptables of yurthub.

the reason as following:

We originally expected that these iptables configurations would help clients in the container network to have access to yurthub's dummy interface, but in fact many situations prevented yurthub from running and caused confusion for users. At the same time, we found that without these iptables configurations, clients in the container network can still access the yurthub's dummy interface, so removing these configurations would be a better choice.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

disable iptables setting of Yurthub component by default, and we will remove iptables setting in the future. this means we will remove parameter --enable-iptables of yurthub.

the reason as following:

We originally expected that these iptables configurations would help clients in the container network to have access to yurthub's dummy interface, but in fact many situations prevented yurthub from running and caused confusion for users. At the same time, we found that without these iptables configurations, clients in the container network can still access the yurthub's dummy interface, so removing these configurations would be a better choice.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Nov 6, 2023
@openyurt-bot openyurt-bot added approved approved size/S size/S 10-29 labels Nov 6, 2023
@rambohe-ch rambohe-ch force-pushed the disable-iptables-by-default branch 2 times, most recently from ce0d6cf to 740d68b Compare November 7, 2023 07:36
@openyurt-bot openyurt-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Nov 7, 2023
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.1% 1.1% Duplication

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1770 (f80318e) into master (acf9b01) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 26.77%.

@@            Coverage Diff             @@
##           master    #1770      +/-   ##
==========================================
- Coverage   52.21%   52.19%   -0.02%     
==========================================
  Files         172      172              
  Lines       20877    20884       +7     
==========================================
+ Hits        10900    10901       +1     
- Misses       9015     9021       +6     
  Partials      962      962              
Flag Coverage Δ
unittests 52.19% <26.77%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/yurthub/app/options/options.go 94.85% <100.00%> (+0.02%) ⬆️
pkg/yurthub/network/dummyif_linux.go 0.00% <ø> (ø)
...nager/controller/raven/dns/dns_enqueue_handlers.go 41.37% <100.00%> (ø)
pkg/yurthub/certificate/manager/manager.go 75.71% <0.00%> (-3.40%) ⬇️
pkg/yurthub/network/network.go 0.00% <0.00%> (ø)
...rnalservice/gateway_internal_service_controller.go 48.14% <33.33%> (ø)
...r/raven/gatewaypickup/gateway_pickup_controller.go 24.89% <12.50%> (ø)
...n/gatewaypickup/gateway_pickup_enqueue_handlers.go 0.00% <0.00%> (ø)
...yurtmanager/controller/raven/dns/dns_controller.go 29.87% <25.00%> (ø)
...publicservice/gateway_public_service_controller.go 39.14% <50.00%> (ø)
... and 2 more

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YTGhost YTGhost merged commit 72d8330 into openyurtio:master Nov 7, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants