Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ca data for yurthub component #1815

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

add function GetCAData() to improve ca file preparation for yurthub component.

Which issue(s) this PR fixes:

Fixes #1782

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Nov 20, 2023
@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

add function GetCAData() to improve ca file preparation for yurthub component.

Which issue(s) this PR fixes:

Fixes #1782

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added approved approved size/L size/L: 100-499 labels Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 392 lines in your changes are missing coverage. Please review.

Comparison is base (15bd83b) 52.22% compared to head (e05b7e5) 52.15%.
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/yurthub/storage/disk/storage.go 0.00% 29 Missing ⚠️
pkg/yurthub/yurtcoordinator/coordinator.go 0.00% 28 Missing ⚠️
pkg/yurthub/cachemanager/cache_manager.go 31.42% 24 Missing ⚠️
pkg/yurthub/certificate/token/token.go 0.00% 17 Missing ⚠️
...publicservice/gateway_public_service_controller.go 0.00% 14 Missing ⚠️
...troller/nodelifecycle/node_lifecycle_controller.go 0.00% 13 Missing ⚠️
pkg/yurttunnel/trafficforward/dns/dns.go 23.52% 13 Missing ⚠️
...n/gatewaypickup/gateway_pickup_enqueue_handlers.go 0.00% 12 Missing ⚠️
...yurthub/yurtcoordinator/certmanager/certmanager.go 15.38% 11 Missing ⚠️
pkg/yurthub/storage/etcd/keycache.go 25.00% 9 Missing ⚠️
... and 61 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1815      +/-   ##
==========================================
- Coverage   52.22%   52.15%   -0.07%     
==========================================
  Files         172      172              
  Lines       20840    20863      +23     
==========================================
- Hits        10884    10882       -2     
- Misses       8999     9021      +22     
- Partials      957      960       +3     
Flag Coverage Δ
unittests 52.15% <7.98%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YTGhost YTGhost merged commit 299c5f9 into openyurtio:master Nov 21, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]improve YurtClientCertificateManager interface in yurthub component
3 participants