Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redundant logs #1817

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

River-sh
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@River-sh: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Nov 21, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: River-sh
To complete the pull request process, please assign luckymrwang
You can assign the PR to them by writing /assign @luckymrwang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@River-sh River-sh force-pushed the optimize_controllers_logs branch from 043843c to 3a5b53a Compare November 21, 2023 10:28
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (299c5f9) 52.21% compared to head (3a5b53a) 52.18%.

Files Patch % Lines
...rnalservice/gateway_internal_service_controller.go 10.00% 14 Missing and 4 partials ⚠️
...yurtmanager/controller/raven/dns/dns_controller.go 30.76% 9 Missing ⚠️
...rvice/gateway_internal_service_enqueue_handlers.go 0.00% 7 Missing ⚠️
...r/raven/gatewaypickup/gateway_pickup_controller.go 0.00% 6 Missing ⚠️
...publicservice/gateway_public_service_controller.go 0.00% 5 Missing ⚠️
...service/gateway_public_service_enqueue_handlers.go 0.00% 4 Missing ⚠️
...n/gatewaypickup/gateway_pickup_enqueue_handlers.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
- Coverage   52.21%   52.18%   -0.04%     
==========================================
  Files         172      172              
  Lines       20863    20843      -20     
==========================================
- Hits        10894    10877      -17     
+ Misses       9010     9005       -5     
- Partials      959      961       +2     
Flag Coverage Δ
unittests 52.18% <17.46%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

/rerun

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Nov 23, 2023
@rambohe-ch rambohe-ch merged commit 63c1322 into openyurtio:master Nov 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants