Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print out all registered controllers #1824

Merged
merged 1 commit into from
Nov 24, 2023
Merged

print out all registered controllers #1824

merged 1 commit into from
Nov 24, 2023

Conversation

MeenuyD
Copy link
Contributor

@MeenuyD MeenuyD commented Nov 23, 2023

it is easy to verify which controllers are registered if register log is printed out, so improve the log print of controller register in the entry point instead of in each controller register function.
#1813

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Nov 23, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (299c5f9) 52.21% compared to head (bbc55c9) 52.17%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1824      +/-   ##
==========================================
- Coverage   52.21%   52.17%   -0.05%     
==========================================
  Files         172      172              
  Lines       20863    20843      -20     
==========================================
- Hits        10894    10875      -19     
+ Misses       9010     9007       -3     
- Partials      959      961       +2     
Flag Coverage Δ
unittests 52.17% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MeenuyD, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Nov 24, 2023
@rambohe-ch
Copy link
Member

/lgtm

1 similar comment
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Nov 24, 2023
@rambohe-ch rambohe-ch merged commit ad93a6d into openyurtio:master Nov 24, 2023
14 checks passed
@rambohe-ch
Copy link
Member

Fixes #1813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants