Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:readme slack url #1945

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix:readme slack url #1945

merged 2 commits into from
Feb 5, 2024

Conversation

karthik507
Copy link
Contributor

Readme file update with new slack url , kindly update the new url.

@YTGhost
Copy link
Member

YTGhost commented Feb 5, 2024

@karthik507 The revised link is not the same as the one @rambohe-ch provided before?

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c3b3cb) 51.98% compared to head (2322cd0) 52.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
+ Coverage   51.98%   52.03%   +0.04%     
==========================================
  Files         174      174              
  Lines       21213    21213              
==========================================
+ Hits        11028    11038      +10     
+ Misses       9210     9201       -9     
+ Partials      975      974       -1     
Flag Coverage Δ
unittests 52.03% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karthik507
Copy link
Contributor Author

@karthik507 The revised link is not the same as the one @rambohe-ch provided before?

@YTGhost the link which you gave was working url :https://join.slack.com/t/openyurt/shared_invite/zt-2bptiyzuv-oDDlfdLwS0AuxSyD4cq4eA and @rambohe-ch url was different and that was also working ,i updated the url which you gave.

@YTGhost
Copy link
Member

YTGhost commented Feb 5, 2024

@karthik507 The revised link is not the same as the one @rambohe-ch provided before?

@YTGhost the link which you gave was working url :https://join.slack.com/t/openyurt/shared_invite/zt-2bptiyzuv-oDDlfdLwS0AuxSyD4cq4eA and @rambohe-ch url was different and that was also working ,i updated the url which you gave.

The URL I provided appears to expire, but @rambohe-ch gave does not. Please change it to the one he provided.

@karthik507
Copy link
Contributor Author

@karthik507 The revised link is not the same as the one @rambohe-ch provided before?

@YTGhost the link which you gave was working url :https://join.slack.com/t/openyurt/shared_invite/zt-2bptiyzuv-oDDlfdLwS0AuxSyD4cq4eA and @rambohe-ch url was different and that was also working ,i updated the url which you gave.

The URL I provided appears to expire, but @rambohe-ch gave does not. Please change it to the one he provided.

@YTGhost okay

Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Feb 5, 2024
@rambohe-ch rambohe-ch merged commit 3e5d8fc into openyurtio:master Feb 5, 2024
13 checks passed
@rambohe-ch
Copy link
Member

Fixes #1944

zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants