Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close dst file #2046

Merged
merged 1 commit into from
May 17, 2024
Merged

fix: close dst file #2046

merged 1 commit into from
May 17, 2024

Conversation

testwill
Copy link
Contributor

@testwill testwill commented May 14, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

pkg/util/file/file.go Outdated Show resolved Hide resolved
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.37%. Comparing base (37addb5) to head (61b3d9f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2046   +/-   ##
=======================================
  Coverage   55.37%   55.37%           
=======================================
  Files         185      185           
  Lines       17821    17821           
=======================================
  Hits         9869     9869           
  Misses       6934     6934           
  Partials     1018     1018           
Flag Coverage Δ
unittests 55.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels May 17, 2024
@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch merged commit df38199 into openyurtio:master May 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants