Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature:Support specified kubeadm conf for join cluster #210

Conversation

liangyuanpeng
Copy link
Member

Ⅰ. Describe what this PR does

Support specified kubeadm conf for join cluster

Ⅱ. Does this pull request fix one issue?

fixes #203

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

  1. build yurtctl
make WHAT=cmd/yurtctl
  1. convert cluster

yurtctl convert --yurt-controller-manager-image=registry.cn-hangzhou.aliyuncs.com/openyurt/yurt-controller-manager:v0.2.1 --yurt-tunnel-agent-image=registry.cn-hangzhou.aliyuncs.com/openyurt/yurt-tunnel-agent:v0.2.1 --yurt-tunnel-server-image=registry.cn-hangzhou.aliyuncs.com/openyurt/yurt-tunnel-server:v0.2.1 --yurtctl-servant-image=registry.cn-hangzhou.aliyuncs.com/openyurt/yurtctl-servant:v0.2.1 --yurthub-image=registry.cn-hangzhou.aliyuncs.com/openyurt/yurthub:v0.2.1 --cloud-nodes=kube232 --deploy-yurttunnel --kubeadm-conf-path=/usr/lib/systemd/system/kubelet.service.d/10-kubeadm.conf

  1. revert cluster

yurtctl revert --yurtctl-servant-image=registry.cn-hangzhou.aliyuncs.com/openyurt/yurtctl-servant:v0.2.1 --kubeadm-conf-path=/usr/lib/systemd/system/kubelet.service.d/10-kubeadm.conf

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2021

CLA assistant check
All committers have signed the CLA.

@liangyuanpeng liangyuanpeng force-pushed the feature_support_specified_kubeadmconf branch from ad81525 to 5b8e531 Compare January 28, 2021 05:10
@rambohe-ch
Copy link
Member

LGTM

@Fei-Guo Fei-Guo merged commit 18a2bdb into openyurtio:master Feb 2, 2021
wawlian pushed a commit to wawlian/openyurt that referenced this pull request Feb 8, 2021
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Mar 31, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Command convert of yurtctl support param for kubelet service kubeadm conf
4 participants