Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add edge-pod-network doc #302

Merged
merged 1 commit into from
May 20, 2021
Merged

add edge-pod-network doc #302

merged 1 commit into from
May 20, 2021

Conversation

wenjun93
Copy link
Member

@wenjun93 wenjun93 commented May 18, 2021

Ⅰ. Describe what this PR does

add doc for edge pod network.

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@rambohe-ch
Copy link
Member

@wenjun93 Thank you for adding the doc of edge pod network. and how about add the following the contents:

  1. the background of the pod network autonomy
  2. the problems for making sure pod network autonomy

and then explain the solutions of problems.
by the way, It is easier to understand if an arch pic of edge pod network can be added.

@wenjun93 wenjun93 force-pushed the doc branch 8 times, most recently from 2fd8e69 to bf9ec13 Compare May 18, 2021 09:06
@wenjun93
Copy link
Member Author

wenjun93 commented May 18, 2021

@wenjun93 Thank you for adding the doc of edge pod network. and how about add the following the contents:

  1. the background of the pod network autonomy
  2. the problems for making sure pod network autonomy

and then explain the solutions of problems.
by the way, It is easier to understand if an arch pic of edge pod network can be added.

@rambohe-ch updated

@Fei-Guo
Copy link
Member

Fei-Guo commented May 18, 2021

  1. Please fix the lint errors
  2. Is this possible to show the code diff if the patch is simple?

Especially the local IPAM plugin change is requested by many users many times. It will be nice to provide more details so that user can DIY.

@wenjun93 wenjun93 force-pushed the doc branch 2 times, most recently from 7b43f15 to f415b87 Compare May 19, 2021 03:01
@wenjun93
Copy link
Member Author

@Fei-Guo The doc proposed

  1. Please fix the lint errors
  2. Is this possible to show the code diff if the patch is simple?

Especially the local IPAM plugin change is requested by many users many times. It will be nice to provide more details so that user can DIY.

the patch is not simply a few lines of code change, we might discuss it.

@wenjun93 wenjun93 force-pushed the doc branch 3 times, most recently from 7f04eb6 to a9e6416 Compare May 20, 2021 03:04
@Fei-Guo Fei-Guo merged commit 506e826 into openyurtio:master May 20, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Co-authored-by: 文俊 <vincent.gwj@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants