-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add data filtering framework #394
feature: add data filtering framework #394
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d3d74a3
to
d7083cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM.
We need to add tests in the future change.
} | ||
|
||
// filterInitializer is responsible for initializing filter | ||
type filterInitializer struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to rename this to "genericFilterInitializer".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
1. support endpointslice filter for keeping service traffic in-bound of nodePool 2. support master service mutation for pod use InClusterConfig access kube-apiserver
d7083cd
to
94cd5d9
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fei-Guo, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1. support endpointslice filter for keeping service traffic in-bound of nodePool 2. support master service mutation for pod use InClusterConfig access kube-apiserver
What type of PR is this?
/kind feature
What this PR does / why we need it:
add data filtering framework
you can check the proposal here: #388
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/assign @Fei-Guo
Does this PR introduce a user-facing change?
other Note