-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support proxy https request from cloud to edge through yurt-tunnel #442
feature: support proxy https request from cloud to edge through yurt-tunnel #442
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
842858e
to
8643d21
Compare
pkg/yurttunnel/util/util.go
Outdated
} | ||
|
||
// field dnat-ports-pair will be deprecated in future version | ||
pairStr, ok := cm.Data[yurttunnelServerDnatDataKey] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you can dedup the code 102-115 with 119-134 by introducing at local function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fei-Guo It's a good idea, fixed it.
@@ -129,6 +129,8 @@ metadata: | |||
name: __project_prefix__-tunnel-server-cfg | |||
namespace: kube-system | |||
data: | |||
http-proxy-ports: "" | |||
https-proxy-ports: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using an array rather than a comma-separated string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DrmagicE
I think comma-separated string is more simpler than array string for user to edit fields in configmap resource. because array string like the following setting:
http-proxy-ports: '["aaa", "aaa", "aaa"]'
https-proxy-ports: '["bbb", "bbb", "bbb"]'
so how about keep this comma-separated string design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it is reasonable.
8643d21
to
c097f60
Compare
Please add the copyright headers for all the files that miss it in this change. Otherwise, LGTM. |
c097f60
to
c252e44
Compare
@Fei-Guo ok, copyright headers are added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind feature
What this PR does / why we need it:
10250
and10255
Ports, In order to support more tcp ports of https and http service on edge nodes. use can configure theyurt-tunnel-server-cfg
configmap, and add specified tcp ports inhttps-proxy-ports
andhttp-proxy-port
field of configmap.https://{nodeIP}:9051
andhttp://{ndoeIP}:9052
on edge nodes, you need to configure as following:Which issue(s) this PR fixes:
Fixes #414
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note