Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: move MaxInFlightLimit handler chain after RequestClientComponent #451

Merged

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Sep 6, 2021

Signed-off-by: SataQiu shidaqiu2018@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

MaxInFlightLimit wants to show the client component, but the client component info is available only after RequestClientComponent chain executed.

klog.V(5).Infof("%s request completed, left %d requests in flight", util.ReqString(req), len(reqChan))

comp, _ := ClientComponentFrom(ctx)

This PR move MaxInFlightLimit handler chain after RequestClientComponent.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

bugfix: move 'MaxInFlightLimit' handler chain after 'RequestClientComponent'

other Note

Signed-off-by: SataQiu <shidaqiu2018@gmail.com>
@rambohe-ch
Copy link
Member

/lgtm
/approve

Generally, you are advised to set the yurthub log level to --v=2

@openyurt-bot openyurt-bot added the lgtm lgtm label Sep 7, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 7, 2021
@openyurt-bot openyurt-bot merged commit 08cb31c into openyurtio:master Sep 7, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
…ent (openyurtio#451)

Signed-off-by: SataQiu <shidaqiu2018@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants