-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some unit tests for yurt tunnel #470
Conversation
Welcome @YRXING! It looks like this is your first PR to openyurtio/openyurt 🎉 |
@YRXING Please add the license header for new files. btw: fix the lint errors and unit-test failed cases. |
@YRXING please merge these six commits into one commit. |
@YRXING please fix the following errors. |
@YRXING please merge all commits into one commit. |
I have format the project but golangci-lint still failed. |
@YRXING On my local desktop, the golangci-lint errors as following:
|
@YRXING you need to install goimports command and reformat the above code files. and if you use goland to edit golang code, you can right click above files and select |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, YRXING The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@YRXING Would you like to apply OpenYurt community member, and you can add me as sponsor. apply example is here: openyurtio/community#24 |
What type of PR is this?
What this PR does / why we need it:
improve the reliability of yurt-tunnel.
Which issue(s) this PR fixes:
Fixes #416
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE