Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yurthub: stop renew node lease when kubelet's heartbeat is stopped #482

Merged
merged 1 commit into from
Sep 24, 2021
Merged

yurthub: stop renew node lease when kubelet's heartbeat is stopped #482

merged 1 commit into from
Sep 24, 2021

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Sep 18, 2021

What type of PR is this?

/kind bug

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

yurthub: stop renew node lease when kubelet's heartbeat is stopped

Which issue(s) this PR fixes:

Fixes #420

Special notes for your reviewer:

/assign @rambohe-ch @Fei-Guo

Does this PR introduce a user-facing change?

yurthub: improve the healthy check mechanism when kubelet's heartbeat stopped

other Note

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Sep 18, 2021
Fei-Guo
Fei-Guo reviewed Sep 19, 2021
View reviewed changes
Copy link
Member

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a heavy solution.
Can we just log the lastKubeletLeaseReqTime in ServerHTTP and just check the timestamp when we send heartbeat to APIServer?

pkg/yurthub/proxy/proxy.go Outdated Show resolved Hide resolved
@rambohe-ch
Copy link
Member

@SataQiu please fix the conflicting files.

@SataQiu
Copy link
Member Author

SataQiu commented Sep 24, 2021

Thanks @rambohe-ch @Fei-Guo
Updated!

@openyurt-bot openyurt-bot added size/M size/M: 30-99 and removed size/L size/L: 100-499 labels Sep 24, 2021
@SataQiu
yurthub: stop renew node lease when kubelet's heartbeat is stopped
150900d 
Signed-off-by: SataQiu <shidaqiu2018@gmail.com>
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 24, 2021
@rambohe-ch rambohe-ch merged commit 7aa7917 into openyurtio:master Sep 24, 2021
@SataQiu SataQiu mentioned this pull request Nov 15, 2021
Merged
6 tasks
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
@rambohe-ch
Merge pull request openyurtio#482 from SataQiu/fix-health-check
1be5351 
yurthub: stop renew node lease when kubelet's heartbeat is stopped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo left review comments

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@kadisi kadisi Awaiting requested review from kadisi

@Peeknut Peeknut Awaiting requested review from Peeknut

Assignees

@Fei-Guo Fei-Guo

@rambohe-ch rambohe-ch

Labels
approved approved size/M size/M: 30-99
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[yurthub]improve the healthy check mechanism when kubelet's heartbeat stopped
4 participants
@SataQiu @rambohe-ch @openyurt-bot @Fei-Guo