-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add check-license-header script to github action #487
Conversation
@lonelyCZ: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @lonelyCZ! It looks like this is your first PR to openyurtio/openyurt 🎉 |
/assign @rambohe-ch |
@lonelyCZ I agree with you that put license check at the begin of github actions. /lgtm |
@lonelyCZ Welcome you to apply OpenYurt community member, and you can add me as sponsor. here is a apply example: openyurtio/community#28 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lonelyCZ, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
feature: add check-license-header script to github action
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #478
Special notes for your reviewer:
I am not sure where the github action should be, but I think it should be in front. Because if the license header missed in files, the following test steps need not to be performed.
Does this PR introduce a user-facing change?
other Note