Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enable-node-pool parameter for yurthub in order to disable nodepools list/watch in filters when testing. #822

Merged
merged 1 commit into from
May 10, 2022
Merged

add enable-node-pool parameter for yurthub in order to disable nodepools list/watch in filters when testing. #822

merged 1 commit into from
May 10, 2022
+19 −5

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind enhancement

What this PR does / why we need it:

add a --enable-node-pool parameter for yurthub component. by setting up --enable-node-pool=false for disabling nodepools list/watch in filters so local-up-openyurt.sh can work when nodepools resource doesn't exist in cluster.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @Congrool

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind enhancement

What this PR does / why we need it:

add a --enable-node-pool parameter for yurthub component. by setting up --enable-node-pool=false for disabling nodepools list/watch in filters so local-up-openyurt.sh can work when nodepools resource doesn't exist in cluster.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @Congrool

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label May 7, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot requested review from Congrool and huangyuqi May 7, 2022 11:43
@openyurt-bot openyurt-bot added approved approved size/S size/S 10-29 labels May 7, 2022
Congrool
Congrool reviewed May 8, 2022
View reviewed changes
Copy link
Member

@Congrool Congrool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks strange to have an API-related option at the edgenode-side.
It's more suitable to diable the module that uses the nodepool resource. It looks like ingressControllerFilter and serviceTopologyFilter use nodepool resource. How about adding option --disable-filters instead of the --enable-node-pool?

@rambohe-ch
Copy link
Member Author

It looks strange to have an API-related option at the edgenode-side. It's more suitable to diable the module that uses the nodepool resource. It looks like ingressControllerFilter and serviceTopologyFilter use nodepool resource. How about adding option --disable-filters instead of the --enable-node-pool?

@Congrool Thanks for your feedback. we already have --disable-filters parameter. In this case(start local-up-openyurt.sh, yurt-app-manager will not be installed) we don't want to disable serviceTopology filter, we only want to disable service traffic inclose of pool topology only, so we can continue use service traffic inclose in node topology ability. so a new parameter --enable-node-pool is added.

@Congrool
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label May 10, 2022
@openyurt-bot openyurt-bot merged commit c84bc31 into openyurtio:master May 10, 2022
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@rambohe-ch @JameKeal
add enable-node-pool parameter for yurthub in order to disable nodepo…
5d95aaa 
…ols list/watch in filters when testing. (openyurtio#822)
openyurt-bot pushed a commit that referenced this pull request May 16, 2022
@JameKeal @Congrool
@cndoit18 @pengbinbin1 @MrGirl @rambohe-ch @lonelyCZ
【ADD】Uniform use processCreateErr func to create resource (#828)
536db52 
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* fix git safe dir error (#807)

Signed-off-by: Congrool <chpzhangyifei@zju.edu.cn>

* 【Optimize】unified image pull policy (#805)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* unified image pull policy

* 【Optimize】optimize kubernetes util function (#808)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* optimize kubernetes util func

* 【FIX】fix cloud node was heterogeneous (#806)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* fix bug: when cloud node was heterogeneous, this parameter will be error

* cleanup: io/ioutil (#813)

Signed-off-by: cndoit18 <cndoit18@outlook.com>

* use constants instead the string (#814)

* ingress: update edge ingress proposal to add enhancement (#816)

* finish ut of sa token replacement (#787)

* finish ut of sa token replacement
add tenant sa token subsitute

* add tenant sa token subsitute

* add enable-node-pool parameter for yurthub in order to disable nodepools list/watch in filters when testing. (#822)

* Remove convert and revert command (#826)

Signed-off-by: lonelyCZ <531187475@qq.com>

* uniform processCreateErr func to deal the resource create

Co-authored-by: Yifei Zhang <chpzhangyifei@zju.edu.cn>
Co-authored-by: cndoit18 <cndoit18@outlook.com>
Co-authored-by: pengbinbin1 <pengbiny@163.com>
Co-authored-by: zzguang <zhengguang.zhang@intel.com>
Co-authored-by: MrGirl <wuyingxingzyd@163.com>
Co-authored-by: rambohe <linbo.hlb@alibaba-inc.com>
Co-authored-by: Zhe Cheng <47743202+lonelyCZ@users.noreply.github.com>
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@rambohe-ch @JameKeal
add enable-node-pool parameter for yurthub in order to disable nodepo…
4588ae5 
…ols list/watch in filters when testing. (openyurtio#822)
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@rambohe-ch @JameKeal
add enable-node-pool parameter for yurthub in order to disable nodepo…
5180a02 
…ols list/watch in filters when testing. (openyurtio#822)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Congrool Congrool Congrool left review comments

@huangyuqi huangyuqi Awaiting requested review from huangyuqi

Assignees

@Congrool Congrool

Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/S size/S 10-29
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rambohe-ch @openyurt-bot @Congrool