Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge endpoints filter into service topology filter #963

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/kind feature

What this PR does / why we need it:

merge endpoints filter into service topology filter, so service topology feature can have the same ability for all kinds of clients.

Which issue(s) this PR fixes:

Fixes #954

Special notes for your reviewer:

/assign @zzguang

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer, zzguang.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/kind feature

What this PR does / why we need it:

merge endpoints filter into service topology filter, so service topology feature can have the same ability for all kinds of clients.

Which issue(s) this PR fixes:

Fixes #954

Special notes for your reviewer:

/assign @zzguang

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Aug 24, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #963 (d7b607e) into master (8896ea6) will increase coverage by 0.46%.
The diff coverage is 65.81%.

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   43.59%   44.05%   +0.46%     
==========================================
  Files          83       83              
  Lines       11260    11346      +86     
==========================================
+ Hits         4909     4999      +90     
+ Misses       5914     5912       -2     
+ Partials      437      435       -2     
Flag Coverage Δ
unittests 44.05% <65.81%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurthub/filter/approver.go 75.65% <ø> (ø)
pkg/yurthub/filter/servicetopology/handler.go 59.43% <65.81%> (+18.94%) ⬆️
pkg/util/iptables/iptables.go 87.67% <0.00%> (+0.54%) ⬆️
...troller/nodelifecycle/node_lifecycle_controller.go 56.15% <0.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member Author

/assign @zzguang

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: zzguang.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @zzguang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zzguang
Copy link
Member

zzguang commented Aug 24, 2022

/lgtm

@openyurt-bot
Copy link
Collaborator

@zzguang: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadisi
Copy link
Member

kadisi commented Aug 25, 2022

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Aug 25, 2022
@openyurt-bot openyurt-bot merged commit 277c2eb into openyurtio:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]improve service topology ability for yurthub
4 participants