Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support github container registry #121

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

siredmar
Copy link
Contributor

@siredmar siredmar commented Jul 5, 2023

Same as openyurtio/openyurt#1575

You need to provide the repository secrets GH_REGISTRY_USERNAME and GH_REGISTRY_PASSWORD containing the username that pushes and a PAT (private access token) from github described in the following docs: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry

Signed-off-by: Armin Schlegel <armin.schlegel@gmx.de>
@njucjc njucjc requested a review from rambohe-ch July 5, 2023 07:17
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #121 (19062be) into main (7e50082) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   42.73%   42.73%           
=======================================
  Files           7        7           
  Lines        1053     1053           
=======================================
  Hits          450      450           
  Misses        513      513           
  Partials       90       90           
Flag Coverage Δ
unittests 42.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rambohe-ch
Copy link
Member

Same as openyurtio/openyurt#1575

You need to provide the repository secrets GH_REGISTRY_USERNAME and GH_REGISTRY_PASSWORD containing the username that pushes and a PAT (private access token) from github described in the following docs: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry

@siredmar Env GH_REGISTRY_USERNAME and GH_REGISTRY_PASSWORD are defined as organization envs, so you can use them directly in raven repository.

and would you like to make a pull request to support github container registry?

@siredmar
Copy link
Contributor Author

siredmar commented Jul 5, 2023

@rambohe-ch great using orga secrets.
This is already the PR you are looking at.

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch merged commit 86eb81b into openyurtio:main Jul 5, 2023
11 checks passed
@siredmar siredmar deleted the github_registry branch July 5, 2023 11:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants