Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: raven traffic ignore nat #131

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Jul 27, 2023

Fixes #124

Signed-off-by: Liang Deng <283304489@qq.com>
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #131 (dc359e5) into main (5e8937d) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   42.73%   42.69%   -0.04%     
==========================================
  Files           7        7              
  Lines        1053     1089      +36     
==========================================
+ Hits          450      465      +15     
- Misses        513      534      +21     
  Partials       90       90              
Flag Coverage Δ
unittests 42.69% <30.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/networkengine/routedriver/vxlan/vxlan.go 57.94% <ø> (+2.53%) ⬆️
pkg/networkengine/vpndriver/libreswan/libreswan.go 45.71% <30.00%> (-3.62%) ⬇️

@YTGhost
Copy link
Member Author

YTGhost commented Jul 27, 2023

@njucjc PTAL

@njucjc njucjc requested review from njucjc and BSWANG and removed request for njucjc July 27, 2023 10:45
@njucjc
Copy link
Member

njucjc commented Aug 4, 2023

LGTM

@YTGhost
Copy link
Member Author

YTGhost commented Aug 9, 2023

@BSWANG This pr still needs some modifications based on our last discussion.

@rambohe-ch
Copy link
Member

@YTGhost It seems that unit tests is not enough, please fix it.

@BSWANG BSWANG merged commit 221a303 into openyurtio:main Aug 9, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Avoid nat when there is only a single node at endpoints in the Gateway
4 participants