Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

apps.openyurt.io/v1beta1 NodePool #104

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

huiwq1990
Copy link
Member

Signed-off-by: huiwq1990 huiwq1990@163.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##77

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #104 (e129900) into master (a1226f5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   21.87%   21.87%           
=======================================
  Files          23       23           
  Lines        2647     2647           
=======================================
  Hits          579      579           
  Misses       1986     1986           
  Partials       82       82           
Flag Coverage Δ
unittests 21.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: huiwq1990 <huiwq1990@163.com>
@rambohe-ch
Copy link
Member

@huiwq1990 Thank you post pull request for v1beta1.NodePool. and will you update the API definition onto the homepage website?

@rambohe-ch
Copy link
Member

@huiwq1990 Thank you post pull request for v1beta1.NodePool. and will you update the API definition onto the homepage website?

@huiwq1990 as we discussed, i have raised a issue: openyurtio/openyurt#953, so we will manage all API definition in openyurtio/api repo.

@openyurt-bot openyurt-bot added the approved approved label Aug 18, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit cf1f65a into openyurtio:master Aug 18, 2022
@rambohe-ch
Copy link
Member

Fixes #77

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants