Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

ingress: add nodepool edge node taints tolerations #38

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

zzguang
Copy link
Member

@zzguang zzguang commented Feb 14, 2022

When nginx ingress controller is orchestrated to the related nodepools by YurtIngress,
it can not be orchestrated successfully to the nodepool edge nodes with taints for the
related deployment didn't add the related tolerations. As a system component, we keep
it tranparent to users and set it to tolerate all taints for the nodepool nodes.

Signed-off-by: zhenggu1 zhengguang.zhang@intel.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

When nginx ingress controller is orchestrated to the related nodepools by YurtIngress,
it can not be orchestrated successfully to the nodepool edge nodes with taints for the
related deployment didn't add the related tolerations. As a system component, we keep
it tranparent to users and set it to tolerate all taints for the nodepool nodes.

Signed-off-by: zhenggu1 <zhengguang.zhang@intel.com>
@openyurt-bot
Copy link
Collaborator

@zzguang: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

When nginx ingress controller is orchestrated to the related nodepools by YurtIngress,
it can not be orchestrated successfully to the nodepool edge nodes with taints for the
related deployment didn't add the related tolerations. As a system component, we keep
it tranparent to users and set it to tolerate all taints for the nodepool nodes.

Signed-off-by: zhenggu1 zhengguang.zhang@intel.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Feb 14, 2022
@zzguang
Copy link
Member Author

zzguang commented Feb 14, 2022

/assign @kadisi @rambohe-ch

@kadisi
Copy link
Member

kadisi commented Feb 15, 2022

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Feb 15, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadisi, zzguang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants