ingress: add YurtIngress enhancement features #51
Conversation
Signed-off-by: Linda Yu <linda.yu@intel.com>
Signed-off-by: zhenggu1 <zhengguang.zhang@intel.com>
|
@zzguang: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @kadisi |
When the ingress controller service for a nodepool is exposed, user can set the service external IP by the new added API in YurtIngress CR. Signed-off-by: zzguang <zhengguang.zhang@intel.com>
nginx ingress controller image and webhook certgen image are hard-coded in the previous version, which is not friendly to users, so add the API for users to config the related images locations themselves, which means users can upgrade the nginx ingress controller as well. Note: for the nginx ingress controller version has a relationship with the kubernetes version, when users config the nginx ingress controller image, they should ensure these 2 versions are matchable. Signed-off-by: zzguang <zhengguang.zhang@intel.com>
Signed-off-by: zzguang <zhengguang.zhang@intel.com>
When yurt-app-manager is deleted, some nginx ingress controller related resources can not be cleaned up or garbage collected, add ownerReferences to these resources to avoid this issue. Signed-off-by: zzguang <zhengguang.zhang@intel.com>
| func SetDefaultsYurtIngress(obj *YurtIngress) { | ||
|
|
||
| if obj.Spec.IngressControllerImage == "" { | ||
| obj.Spec.IngressControllerImage = "k8s.gcr.io/ingress-nginx/controller:v0.48.1" |
| } | ||
| if obj.Spec.IngressWebhookCertGenImage == "" { | ||
| obj.Spec.IngressWebhookCertGenImage = "docker.io/jettech/kube-webhook-certgen:v1.5.1" | ||
| } |
Signed-off-by: zzguang <zhengguang.zhang@intel.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadisi, zzguang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Add YurtIngress enhancement features to provide users more flexibility for configuration, which mainly includes:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note