Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

add additional print columns to show more information #26

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

qclc
Copy link
Member

@qclc qclc commented Feb 23, 2022

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

  • add additional print columns to show more information when using kubectl

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @wawlian

Does this PR introduce a user-facing change?

This PR fixes a capital error in one of the CRD fields (deviceProfile.status.Synced -> deviceProfile.status.synced). This CRD is incompatible with v0.1.0 Yurt-Device-Controller. Therefore, the latest version of Yurt-Device-Controller is required when the CRD is applied.

other Note

@openyurt-bot
Copy link

@qclc: GitHub didn't allow me to assign the following users: wawlian, your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

  • add additional print columns to show more information when using kubectl

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @wawlian

Does this PR introduce a user-facing change?

This PR fixes a capital error in one of the CRD fields (deviceProfile.status.Synced -> deviceProfile.status.synced). This CRD is incompatible with v0.1.0 Yurt-Device-Controller. Therefore, the latest version of Yurt-Device-Controller is required when the CRD is applied.

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link

@qclc: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

  • add additional print columns to show more information when using kubectl

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @wawlian

Does this PR introduce a user-facing change?

This PR fixes a capital error in one of the CRD fields (deviceProfile.status.Synced -> deviceProfile.status.synced). This CRD is incompatible with v0.1.0 Yurt-Device-Controller. Therefore, the latest version of Yurt-Device-Controller is required when the CRD is applied.

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qclc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wawlian
Copy link
Contributor

wawlian commented Apr 7, 2022

@qclc maybe you can add short names for these three resource types in this pr.

@qclc qclc force-pushed the add-print-columns branch from bb84a99 to 385ce65 Compare April 7, 2022 07:45
@qclc
Copy link
Member Author

qclc commented Apr 7, 2022

@qclc maybe you can add short names for these three resource types in this pr.

The short names are added,please take a look. @wawlian

@qclc qclc force-pushed the add-print-columns branch 4 times, most recently from 98e7f1a to 9990e86 Compare April 7, 2022 09:22
@qclc qclc force-pushed the add-print-columns branch from 9990e86 to 3ec437a Compare April 11, 2022 08:29
@wawlian
Copy link
Contributor

wawlian commented Apr 11, 2022

/lgtm

@openyurt-bot
Copy link

@wawlian: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qclc qclc merged commit b63c7b4 into openyurtio:main Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants