Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

add tutorial for release v0.2.0 to support EdgeX 2.1 #35

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

wawlian
Copy link
Contributor

@wawlian wawlian commented May 31, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #34

Special notes for your reviewer:

/assign @lwmqwer @gnunu

Does this PR introduce a user-facing change?

NONE

@openyurt-bot
Copy link

@wawlian: The label(s) kind/documentation cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #34

Special notes for your reviewer:

/assign @lwmqwer @gnunu

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

docs/yurt-device-controller-tutorial-v1.md Show resolved Hide resolved
docs/yurt-device-controller-tutorial-v2.md Outdated Show resolved Hide resolved
docs/yurt-device-controller-tutorial-v2.md Show resolved Hide resolved
docs/yurt-device-controller-tutorial-v2.md Outdated Show resolved Hide resolved
@lwmqwer
Copy link
Member

lwmqwer commented Jun 1, 2022

I think we should put the tutorial of device-controller and edge manager together. Give the use all-in-one doc to install, deployment, test rather than a separate docs in many places

@rambohe-ch
Copy link
Member

I think we should put the tutorial of device-controller and edge manager together. Give the use all-in-one doc to install, deployment, test rather than a separate docs in many places

@lwmqwer agree +1

@wawlian wawlian force-pushed the doc/revise-tutorial branch from 5e7f556 to fd3a281 Compare June 1, 2022 06:47
@wawlian
Copy link
Contributor Author

wawlian commented Jun 1, 2022

@rambohe-ch @lwmqwer Provide an all-in-one tutorial is fine. But maybe openyurt.io is a better place. This tutorial as an updated version puts more emphasis on how to manage edge devices through yurt-device-controller from OpenYurt/K8S side.

@wawlian wawlian requested a review from gnunu June 1, 2022 08:01
apiVersion: device.openyurt.io/v1alpha1
kind: DeviceService
metadata:
name: openyurt-created-deviceservuce-virtual
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deviceservuce -> deviceservice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

other:
Address: openyurt-created-device-virtual-bool-01
Port: "300"
serviceName: openyurt-created-deviceservuce-virtual
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deviceservuce -> deviceservice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@lwmqwer
Copy link
Member

lwmqwer commented Jun 1, 2022

@wawlian correct, neither of device or edgex is suit for this tutorial . But I mean is that we can just write a all-in-one and give the link in edgex and device is enough.

@wawlian wawlian force-pushed the doc/revise-tutorial branch from fd3a281 to 2fab930 Compare June 1, 2022 09:53
@wawlian wawlian requested a review from gnunu June 1, 2022 10:25
@gnunu
Copy link
Member

gnunu commented Jun 2, 2022

/LGTM

@openyurtio openyurtio deleted a comment from openyurt-bot Jun 4, 2022
Copy link
Member

@qclc qclc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openyurt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qclc, wawlian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 842f37b into openyurtio:main Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] add docs about how to use OpenYurt to manage devices with EdgeX v2
6 participants