Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

add API test for device/deviceprofile/deviceservice #49

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

LindaYu17
Copy link
Member

run: make test

Signed-off-by: Linda Yu linda.yu@intel.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@LindaYu17
Copy link
Member Author

ok github.com/openyurtio/device-controller/pkg/controllers 21.626s coverage: 20.7% of statements
ok github.com/openyurtio/device-controller/pkg/controllers/util 0.016s coverage: 44.8% of statements

@codecov-commenter
Copy link

Codecov Report

Merging #49 (ea5a3f6) into main (3306b9e) will increase coverage by 22.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            main      #49       +/-   ##
==========================================
+ Coverage   0.00%   22.39%   +22.39%     
==========================================
  Files          7       10        +3     
  Lines        834      920       +86     
==========================================
+ Hits           0      206      +206     
+ Misses       834      676      -158     
- Partials       0       38       +38     
Impacted Files Coverage Δ
pkg/controllers/util/fieldindexer.go 0.00% <0.00%> (ø)
pkg/controllers/util/string.go 100.00% <0.00%> (ø)
pkg/controllers/util/tools.go 42.59% <0.00%> (ø)
pkg/controllers/device_controller.go 27.77% <0.00%> (+27.77%) ⬆️
pkg/controllers/deviceservice_controller.go 43.38% <0.00%> (+43.38%) ⬆️
pkg/controllers/predicate.go 45.00% <0.00%> (+45.00%) ⬆️
pkg/controllers/deviceprofile_controller.go 56.04% <0.00%> (+56.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wawlian
Copy link
Contributor

wawlian commented Aug 16, 2022

/LGTM

Copy link
Member

@qclc qclc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openyurt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnunu, LindaYu17, qclc, wawlian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wawlian wawlian merged commit ed75419 into openyurtio:main Aug 16, 2022
run: make test

Signed-off-by: Linda Yu <linda.yu@intel.com>
@LindaYu17 LindaYu17 deleted the ut branch August 17, 2022 01:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants