Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

add unit tests for edgex client #56

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

wawlian
Copy link
Contributor

@wawlian wawlian commented Aug 30, 2022

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Add unit tests for edgex client.

Which issue(s) this PR fixes:

Fixes #41

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #56 (7c0efc6) into main (2fa8ab1) will increase coverage by 23.09%.
The diff coverage is 92.98%.

@@             Coverage Diff             @@
##             main      #56       +/-   ##
===========================================
+ Coverage   22.30%   45.40%   +23.09%     
===========================================
  Files          10       14        +4     
  Lines         919     1729      +810     
===========================================
+ Hits          205      785      +580     
- Misses        676      837      +161     
- Partials       38      107       +69     
Impacted Files Coverage Δ
pkg/clients/edgex-foundry/device_client.go 56.41% <80.95%> (ø)
pkg/clients/edgex-foundry/deviceservice_client.go 56.07% <100.00%> (ø)
pkg/clients/edgex-foundry/util.go 92.10% <100.00%> (ø)
pkg/clients/edgex-foundry/deviceprofile_client.go 56.81% <0.00%> (ø)
pkg/controllers/deviceservice_controller.go 44.11% <0.00%> (+0.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnunu, lwmqwer, wawlian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lwmqwer
Copy link
Member

lwmqwer commented Aug 31, 2022

/lgtm

@wawlian wawlian merged commit 95b5ab9 into openyurtio:main Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[unit test] improve unit test coverage for yurt-device-controller
4 participants