Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

add helm chart for yurt-device-controller #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wawlian
Copy link
Contributor

@wawlian wawlian commented Sep 27, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #42

Special notes for your reviewer:

/assign @gnunu @lwmqwer

Does this PR introduce a user-facing change?

NONE

@openyurt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wawlian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wawlian wawlian requested review from gnunu and lwmqwer and removed request for yixingjia and rambohe-ch September 27, 2022 12:46
@wawlian wawlian assigned wawlian and unassigned gnunu and lwmqwer Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #57 (049e9ac) into main (95b5ab9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   45.40%   45.40%           
=======================================
  Files          14       14           
  Lines        1729     1729           
=======================================
  Hits          785      785           
  Misses        837      837           
  Partials      107      107           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -0,0 +1,79 @@
apiVersion: apps.openyurt.io/v1alpha1
kind: UnitedDeployment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use yurtappset?

@wawlian wawlian requested a review from gnunu September 28, 2022 07:21
@gnunu
Copy link
Member

gnunu commented Nov 29, 2022

@wawlian
should this be merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]add helm chart for this component
4 participants