Updated and corrected build instructions. #166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding python{,3}-packaging to the build requirements, I
suspected that the build instructions hadn't actually been tested
recently. So I checked, found problems, and corrected them.
Briefly:
(The alternative of putting a shared Debian/Ubuntu command and then additional Debian/Ubuntu specific steps below it seemed to me to be likely to cause confusion; I can do that instead if people disagree.)
I've tested these instructions with:
And it successfully built {deb,rpm}-{kmod,dkms,utils} as appropriate (except on mips64el, but that seems to just be broken on the platform, not a problem of a missing dependency)
(If openzfs/zfs#12102 lands, I can instead drop the -packaging additions and rewrite the checks from openzfs/zfs#12073 that are the whole reason for adding the requirement...)