Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one liner install command does not work #238

Closed
wants to merge 1 commit into from

Conversation

p4tpr0
Copy link

@p4tpr0 p4tpr0 commented Dec 14, 2021

the one-liner "dnf install epel-release kernel-devel zfs" does not work as intended, at least on RockyLinux 8.5. You need to break the line in 2 commands: one for epel and one for other two packages.

the one-liner "dnf install epel-release kernel-devel zfs" does not work as intended, at least on RockyLinux 8.5. You need to break the line in 2 commands: one for epel and one for other two packages.
Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem with this, but I can't say I understand the issue either. I certainly have not tested. So I'm not going to merge this, but I did give it a review in case someone else wants that.

@p4tpr0
Copy link
Author

p4tpr0 commented Dec 14, 2021

Problem is, one apparently can't install the 3 packages in one command, it yields to this situation: https://twitter.com/p4tpr0/status/1469732134990618633
Installing epel-release in first command, then installing kernel-devel zfs in a second command is the only way to get it done.

@rlaager
Copy link
Member

rlaager commented Dec 14, 2021

Right, I'm not disagreeing. I was just qualifying my review.

@ghost
Copy link

ghost commented Dec 14, 2021

@rlaager I wrote this part and can confirm this bug. I think it is ready for merging.

Edit: strikethrough.

@ghost
Copy link

ghost commented Dec 14, 2021

Note: apparently we need to separate kernel-devel from zfs during installation. I'll submit a new PR for this.

gmelikov pushed a commit that referenced this pull request Dec 15, 2021
Closes #238
Also see openzfs/zfs#12822

Signed-off-by: Maurice Zhou <jasper@apvc.uk>
@gmelikov
Copy link
Member

Thank you! Fixed as part of #239

@p4tpr0 p4tpr0 deleted the patch-1 branch January 8, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants