Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

VERIFY*() macros evalulate parameters multiple times on failure #684

Closed
DeHackEd opened this issue Feb 17, 2018 · 0 comments
Closed

VERIFY*() macros evalulate parameters multiple times on failure #684

DeHackEd opened this issue Feb 17, 2018 · 0 comments

Comments

@DeHackEd
Copy link
Contributor

Someone in IRC just had a crash in their system with the following error: https://paste.pound-python.org/show/gjjdCxPcRYtmVhyqVxXu/ What's odd is that the statement (0 == 0) implies the result should have been a success. In fact the VERIFY3U macro double-evaluated the arc_buf_alloc_impl call which succeeded the second time. That's a bug.

https://github.com/zfsonlinux/spl/blob/master/include/sys/debug.h#L66
@vozhyk- vozhyk- mentioned this issue Feb 17, 2018
Closed
@DeHackEd DeHackEd mentioned this issue Feb 17, 2018
Merged
tonyhutter pushed a commit to tonyhutter/spl that referenced this issue Mar 6, 2018
@DeHackEd @tonyhutter
Fix multiple evaluations of VERIFY() and ASSERT() on failures
f566a78 
Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: DHE <git@dehacked.net>
Closes openzfs#684 
Closes openzfs#685
tonyhutter pushed a commit that referenced this issue Mar 19, 2018
@DeHackEd @tonyhutter
Fix multiple evaluations of VERIFY() and ASSERT() on failures
610988f 
Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: DHE <git@dehacked.net>
Closes #684
Closes #685
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DeHackEd