Missed a CentOS 8 package requirement. #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't test that EPEL didn't drop the -packaging package between 7 and 8, and deliberately didn't try to install both packaging and distlib, which means I broke the CentOS 8 builds. Let's install it from its new home, the "powertools" repo, instead. Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
|
That's unfortunate. Having additional dependencies on repositories not enabled by default is going to make building your own packages a bit more awkward. |
|
The alternative is telling people to install distlib by default on EL8 and packaging on EL7, which is also perfectly feasible, I just was trying to pick one and stick with it where possible. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't test that EPEL didn't drop the -packaging package between
7 and 8, and deliberately didn't try to install both packaging and
distlib, which means I broke the CentOS 8 bots when openzfs/zfs#12073 goes in. Drat.
Install it from its new home instead.
(This one has been tested on CentOS 8.)