Skip to content

Commit

Permalink
Matt comment feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
  • Loading branch information
pcd1193182 committed Aug 29, 2019
1 parent f660625 commit 2d5d5df
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions module/zfs/metaslab.c
Original file line number Diff line number Diff line change
Expand Up @@ -3553,11 +3553,12 @@ metaslab_sync(metaslab_t *msp, uint64_t txg)
* Normally, we don't want to process a metaslab if there are no
* allocations or frees to perform. However, if the metaslab is being
* forced to condense, it's loaded and we're not beyond the final
* dirty txg, we need to let it through. This prevents an issue where
* metaslabs that need to be condensed but were loaded for other
* reasons could cause a panic here. By only checking the txg in that
* branch of the conditional, we preserve the utility of the VERIFY
* statements in all other cases.
* dirty txg, we need to let it through. Not condensing beyond the
* final dirty txg prevents an issue where metaslabs that need to be
* condensed but were loaded for other reasons could cause a panic
* here. By only checking the txg in that branch of the conditional,
* we preserve the utility of the VERIFY statements in all other
* cases.
*/
if (range_tree_is_empty(alloctree) &&
range_tree_is_empty(msp->ms_freeing) &&
Expand Down

0 comments on commit 2d5d5df

Please sign in to comment.