Skip to content

Commit

Permalink
ZTS: Update deadman_sync threshold
Browse files Browse the repository at this point in the history
Lower the minimum number of expected deadman events from 4 to 3.  All
that is strictly required is a single event to consider the test a
pass.  However, since I've never seen a count of less than 3 reported
by the CI that should be sufficient.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #16575
  • Loading branch information
behlendorf authored Sep 27, 2024
1 parent d7ab281 commit ac8837d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/zfs-tests/tests/functional/deadman/deadman_sync.ksh
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ log_must set_tunable64 DEADMAN_FAILMODE "wait"
default_setup_noexit $DISK1
log_must zpool events -c

# Force each IO to take 10s by allow them to run concurrently.
# Force each IO to take 10s but allow them to run concurrently.
log_must zinject -d $DISK1 -D10000:10 $TESTPOOL

mntpnt=$(get_prop mountpoint $TESTPOOL/$TESTFS)
Expand All @@ -80,11 +80,11 @@ else
fi
log_must zpool events

# Verify at least 4 deadman events were logged. The first after 5 seconds,
# Verify at least 3 deadman events were logged. The first after 5 seconds,
# and another each second thereafter until the delay is clearer.
events=$(zpool events | grep -c ereport.fs.zfs.deadman)
if [ "$events" -lt 4 ]; then
log_fail "Expect >=5 deadman events, $events found"
if [ "$events" -lt 3 ]; then
log_fail "Expect >=3 deadman events, $events found"
fi

log_pass "Verify spa deadman detected a hung txg and $events deadman events"

0 comments on commit ac8837d

Please sign in to comment.