Ask libtool to stop hiding some errors

For #13083, curiously, it did not print the actual error, just that the compile failed with "Error 1". In theory, this flag should cause it to report errors twice sometimes. In practice, I'm pretty okay with reporting some twice if it avoids reporting some never. Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
openzfs · Feb 15, 2022 · dca349b · dca349b
1 parent 3819aaa
commit dca349b
Show file tree

Hide file tree

Showing 15 changed files with 61 additions and 0 deletions.
diff --git a/lib/libavl/Makefile.am b/lib/libavl/Makefile.am
@@ -5,6 +5,10 @@ VPATH = $(top_srcdir)/module/avl/
 # Includes kernel code, generate warnings for large stack frames
 AM_CFLAGS += $(FRAME_LARGER_THAN)
 AM_CFLAGS += -fvisibility=hidden
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libavl.la
 

diff --git a/lib/libefi/Makefile.am b/lib/libefi/Makefile.am
@@ -2,6 +2,10 @@ include $(top_srcdir)/config/Rules.am
 
 AM_CFLAGS += $(LIBUUID_CFLAGS) $(ZLIB_CFLAGS)
 AM_CFLAGS += -fvisibility=hidden
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libefi.la
 

diff --git a/lib/libicp/Makefile.am b/lib/libicp/Makefile.am
@@ -6,6 +6,10 @@ VPATH = \
 
 # Includes kernel code, generate warnings for large stack frames
 AM_CFLAGS += $(FRAME_LARGER_THAN)
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libicp.la
 

diff --git a/lib/libnvpair/Makefile.am b/lib/libnvpair/Makefile.am
@@ -8,6 +8,10 @@ VPATH = \
 # and required CFLAGS for libtirpc
 AM_CFLAGS += $(FRAME_LARGER_THAN) $(LIBTIRPC_CFLAGS)
 AM_CFLAGS += -fvisibility=hidden
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
 
 lib_LTLIBRARIES = libnvpair.la
 

diff --git a/lib/libshare/Makefile.am b/lib/libshare/Makefile.am
@@ -3,6 +3,7 @@ include $(top_srcdir)/config/Rules.am
 DEFAULT_INCLUDES += -I$(srcdir)
 
 AM_CFLAGS += -fvisibility=hidden
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libshare.la
 

diff --git a/lib/libspl/Makefile.am b/lib/libspl/Makefile.am
@@ -2,6 +2,11 @@ include $(top_srcdir)/config/Rules.am
 
 SUBDIRS = include
 
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
+
 noinst_LTLIBRARIES = libspl_assert.la libspl.la
 
 libspl_assert_la_SOURCES = \

diff --git a/lib/libtpool/Makefile.am b/lib/libtpool/Makefile.am
@@ -1,6 +1,10 @@
 include $(top_srcdir)/config/Rules.am
 
 AM_CFLAGS += -fvisibility=hidden
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libtpool.la
 

diff --git a/lib/libunicode/Makefile.am b/lib/libunicode/Makefile.am
@@ -5,6 +5,11 @@ VPATH = $(top_srcdir)/module/unicode
 # Includes kernel code, generate warnings for large stack frames
 AM_CFLAGS += $(FRAME_LARGER_THAN)
 
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
+
 noinst_LTLIBRARIES = libunicode.la
 
 KERNEL_C = \

diff --git a/lib/libuutil/Makefile.am b/lib/libuutil/Makefile.am
@@ -1,5 +1,10 @@
 include $(top_srcdir)/config/Rules.am
 
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
+
 lib_LTLIBRARIES = libuutil.la
 
 include $(top_srcdir)/config/Abigail.am

diff --git a/lib/libzfs/Makefile.am b/lib/libzfs/Makefile.am
@@ -9,6 +9,10 @@ VPATH = \
 AM_CFLAGS += $(NO_UNUSED_BUT_SET_VARIABLE)
 AM_CFLAGS += $(LIBCRYPTO_CFLAGS) $(ZLIB_CFLAGS)
 AM_CFLAGS += -fvisibility=hidden
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
 
 pkgconfig_DATA = libzfs.pc
 

diff --git a/lib/libzfs_core/Makefile.am b/lib/libzfs_core/Makefile.am
@@ -3,6 +3,10 @@ include $(top_srcdir)/config/Rules.am
 pkgconfig_DATA = libzfs_core.pc
 
 AM_CFLAGS += -fvisibility=hidden
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
 
 lib_LTLIBRARIES = libzfs_core.la
 

diff --git a/lib/libzfsbootenv/Makefile.am b/lib/libzfsbootenv/Makefile.am
@@ -3,6 +3,10 @@ include $(top_srcdir)/config/Rules.am
 pkgconfig_DATA = libzfsbootenv.pc
 
 AM_CFLAGS += -fvisibility=hidden
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
 
 lib_LTLIBRARIES = libzfsbootenv.la
 

diff --git a/lib/libzpool/Makefile.am b/lib/libzpool/Makefile.am
@@ -27,6 +27,11 @@ AM_CFLAGS += $(ZLIB_CFLAGS)
 
 AM_CFLAGS += -DLIB_ZPOOL_BUILD
 
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
+
 lib_LTLIBRARIES = libzpool.la
 
 USER_C = \

diff --git a/lib/libzstd/Makefile.am b/lib/libzstd/Makefile.am
@@ -5,6 +5,10 @@ VPATH = $(top_srcdir)/module/zstd
 # -fno-tree-vectorize is set for gcc in zstd/common/compiler.h
 # Set it for other compilers, too.
 AM_CFLAGS += -fno-tree-vectorize
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libzstd.la
 

diff --git a/lib/libzutil/Makefile.am b/lib/libzutil/Makefile.am
@@ -4,6 +4,10 @@ include $(top_srcdir)/config/Rules.am
 AM_CFLAGS += $(NO_UNUSED_BUT_SET_VARIABLE)
 AM_CFLAGS += $(LIBBLKID_CFLAGS) $(LIBUDEV_CFLAGS)
 AM_CFLAGS += -fvisibility=hidden
+# This is a bad hack not consumed by the compiler but by
+# the libtool wrapper, because otherwise it fails to emit
+# errors generated by one compiler run and not the other.
+AM_CFLAGS += -no-suppress
 
 DEFAULT_INCLUDES += -I$(srcdir)