-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for FIDEDUPERANGE #11065
Comments
Are you sure that said function is compatible with ZFS? |
https://man7.org/linux/man-pages/man2/ioctl_fideduperange.2.html "This ioctl operation first appeared in Linux 4.5. It was previously known as BTRFS_IOC_FILE_EXTENT_SAME and was private to Btrfs." Isn't LVM specific, and is already used by BTRFS it seems. "Both files must reside within the same filesystem" I'm by no means an expert on the inner workings of ZFS, but wouldn't this caveat mean this could only be used to dedup within a single dataset? |
At least in some contexts, it should be? ZFS already deduplicates snapshots, for example. I'm not familiar with the more generalised existing ZFS deduplication, but I don't know why it wouldn't prove this function is possible.
If you add such a limitation, it might be nice to have an option to not enforce it. :) |
This basically is a rehash of |
Note that this issue is theoretically unblocked since reflink support has landed. |
This resolves issue openzfs#11065 by implementing FIDUPERANGE on Linux.
This resolves issue openzfs#11065 by implementing FIDUPERANGE on Linux.
Linux 5.4 added an ioctl to inform filesystems of duplicate data, for deduplication. It would be nice if ZFS supported it.
Use case: a cron job could regularly find data to deduplicate without the memory overhead of current ZFS deduplication.
The text was updated successfully, but these errors were encountered: