Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Like 90% of the modctl icp architecture can probably go #12895

Closed
nabijaczleweli opened this issue Dec 21, 2021 · 1 comment
Closed

Like 90% of the modctl icp architecture can probably go #12895

nabijaczleweli opened this issue Dec 21, 2021 · 1 comment
Labels
Component: Encryption "native encryption" feature Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@nabijaczleweli
Copy link
Contributor

Came across it when doing a const-enforcement pass – modctl.h lists a modctl syscall, approximately 17 different module classes, &c. This looks like a straight import from Illumos – neither linux nor freebsd has one. Nor do they have multiple versions of the solaris module loading framework.

This is currently best-effort shimmed out in modconf.c, but it can probably be a tenth of the line count, and much simpler, if we were to rip out the, like, two layers of indirection.

Noting this down to reference in the aforementioned PR and for the future if I need to burn two quality hours.
@nabijaczleweli nabijaczleweli added the Type: Defect Incorrect behavior (e.g. crash, hang) label Dec 21, 2021
@behlendorf behlendorf added the Component: Encryption "native encryption" feature label Dec 22, 2021
@nabijaczleweli nabijaczleweli mentioned this issue Dec 22, 2021
Merged
13 tasks
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 22, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
6b09a8d 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli nabijaczleweli mentioned this issue Dec 22, 2021
Closed
13 tasks
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 22, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
4bb40b9 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 22, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
0650c1b 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 22, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
09b544c 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli nabijaczleweli mentioned this issue Dec 22, 2021
Closed
13 tasks
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 22, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
099cbaf 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 22, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
15cfdcd 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 22, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
c99981a 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 23, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
4f6c01f 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 23, 2021
@nabijaczleweli
module: icp: rip out the Solaris loadable module architecture
fbb62a3 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 23, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
9a82a88 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 25, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
0f91c9c 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli
Copy link
Contributor Author

nabijaczleweli commented Dec 25, 2021 •
edited
Loading

Cf. #12901. icp is made of aerogel. In addition to that thing, it's also got support for rescheduling on hardware providers (there were never any) and software ones (with a flag, never used) (both hotpluggable with a never-used generation system), an entire hashmap implementation used by one file that ends up exactly as long when rewritten in AVL, a notification framework (never used), &c., &c., &c. Systems upon systems upon systems. And by god none of them is a single damn thing.

nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Dec 27, 2021
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
240c48a 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Jan 5, 2022
@nabijaczleweli
module: icp: rip out the Solaris loadable module architecture
8e0b88a 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Jan 5, 2022
@nabijaczleweli
icp: rip out the Solaris loadable module architecture
29f9b71 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
behlendorf pushed a commit that referenced this issue Jan 7, 2022
@nabijaczleweli @behlendorf
module: icp: remove solaris crypto and cryptoadm ioctl definitions
3e310f0 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12895
Closes #12902
behlendorf pushed a commit that referenced this issue Jan 7, 2022
@mcmilk @behlendorf
Remove sha1 hashing from OpenZFS, it's not used anywhere.
a798b48 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12895
Closes #12902
mcmilk pushed a commit to mcmilk/zfs that referenced this issue Jan 7, 2022
@nabijaczleweli @mcmilk
module: icp: rip out the Solaris loadable module architecture
4564e44 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12895
Closes openzfs#12902
mcmilk pushed a commit to mcmilk/zfs that referenced this issue Jan 7, 2022
@nabijaczleweli @mcmilk
module: icp: remove solaris crypto and cryptoadm ioctl definitions
4cf7c73 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12895
Closes openzfs#12902
mcmilk added a commit to mcmilk/zfs that referenced this issue Jan 7, 2022
@mcmilk
Remove sha1 hashing from OpenZFS, it's not used anywhere.
ec831e3 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12895
Closes openzfs#12902
rincebrain pushed a commit to rincebrain/zfs that referenced this issue Jul 15, 2022
@mcmilk @rincebrain
Remove sha1 hashing from OpenZFS, it's not used anywhere.
639d816 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12895
Closes openzfs#12902
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
behlendorf pushed a commit that referenced this issue Jul 26, 2022
@mcmilk @behlendorf
Remove sha1 hashing from OpenZFS, it's not used anywhere.
4b09770 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12895
Closes #12902
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@nabijaczleweli @nicman23
module: icp: rip out the Solaris loadable module architecture
3399eb5 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12895
Closes openzfs#12902
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@nabijaczleweli @nicman23
module: icp: remove solaris crypto and cryptoadm ioctl definitions
0f1d8a4 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12895
Closes openzfs#12902
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@mcmilk @nicman23
Remove sha1 hashing from OpenZFS, it's not used anywhere.
b1f7cfc 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12895
Closes openzfs#12902
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@nabijaczleweli @nicman23
module: icp: rip out the Solaris loadable module architecture
547b13e 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12895
Closes openzfs#12902
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@nabijaczleweli @nicman23
module: icp: remove solaris crypto and cryptoadm ioctl definitions
384b632 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12895
Closes openzfs#12902
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@mcmilk @nicman23
Remove sha1 hashing from OpenZFS, it's not used anywhere.
e48510f 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Attila Fülöp <attila@fueloep.org>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12895
Closes openzfs#12902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Encryption "native encryption" feature Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behlendorf @nabijaczleweli