commit 42aaf0e7c4b9cf0fe9c18d218f291f12dd5b26a2 breaks the FreeBSD build

[markjdb]

System information

Type	Version/Name
Distribution Name	FreeBSD
Distribution Version	14.0-CURRENT
Kernel Version	14.0-CURRENT
Architecture	amd64
OpenZFS Version	latest

Describe the problem you're observing

The kernel module build fails for me when using the system compiler (clang 13.0).

--- zfs_vnops_os.o ---                                                                                                                        
/usr/home/markj/src/zfs/module/os/freebsd/zfs/zfs_vnops_os.c:3706:2: error: invalid application of 'sizeof' to bit-field                      
        ASSERT3S(ZTOV(tdzp)->v_type, ==, VDIR);                                                                                               
        ^                                                                                                                                     
/usr/home/markj/src/zfs/include/os/freebsd/spl/sys/debug.h:138:39: note: expanded from macro 'ASSERT3S'
#define ASSERT3S(x,y,z)         ((void)sizeof(x), (void)sizeof(z))                                                                            
                                             ^                                                                                                

Describe how to reproduce the problem

Build OpenZFS without debugging enabled on FreeBSD-CURRENT. I'm not sure if this is a problem with other compilers.

[behlendorf]

@nabijaczleweli mind taking a look at this, it appears 42aaf0e introduced a build issue.

[nabijaczleweli]

Interesting that CI didn't pick it up, but yeah, sizeof(bitfield.member) is invalid.
@markjdb can you try #12986?

[markjdb]

Interesting that CI didn't pick it up, but yeah, sizeof(bitfield.member) is invalid. @markjdb can you try #12986?

I get this now:

In file included from ../../include/sys/zfs_context.h:97,
                 from ../../module/zstd/zfs_zstd.c:44:
../../include/sys/zstd/zstd.h: In function 'zfs_set_hdrversion':
../../include/sys/bitops.h:53:22: error: suggest parentheses around '+' inside '<<' [-Werror=parentheses]
   53 |  ASSERT3U(val, <, 1U << (len)); \
      |                      ^~
../../lib/libspl/include/assert.h:125:66: note: in definition of macro 'ASSERT3U'
  125 | #define ASSERT3U(x, y, z) ((void) sizeof (x + 0), (void) sizeof (z + 0))
      |                                                                  ^

If I parenthesize the macro parameters, I later get:

In file included from zfs_main.c:36:
zfs_main.c: In function 'zfs_do_clone':
../../lib/libspl/include/assert.h:126:47: error: invalid use of undefined type 'struct zfs_handle'
  126 | #define ASSERT3P(x, y, z) ((void) sizeof ((x) + 0), (void) sizeof ((z) + 0))
      |                                               ^
zfs_main.c:912:2: note: in expansion of macro 'ASSERT3P'
  912 |  ASSERT3P(zhp, ==, NULL);
      |  ^~~~~~~~

[nabijaczleweli]

Hm. Yeah, you can't do pointer arithmetic on pointers-to-incomplete, I guess. I'm, like, almost out of ideas before "dont pass bitfields to asserts". That being said, doing sizeof(!!(x)) seems to be building fine so far – PR updated, please try?

[markjdb]

Thanks, builds fine now.