Commit 48cf170d5 breaks PowerPC build on FreeBSD

[mmatuska]

System information

Type	Version/Name
Distribution Name	FreeBSD
Distribution Version	14.0-CURRENT
Kernel Version	14.0-CURRENT main-n258120-c7046f76c2c0
Architecture	PowerPC
OpenZFS Version	2.1.99-FreeBSD_gc629f0bf6

Describe the problem you're observing

lib/libspl/include/sys/simd.h: getauxval() declared on line 456 is redeclared on line 461

zfs/lib/libspl/include/sys/simd.h

Lines 456 to 461 in c629f0b

	extern unsigned long getauxval(unsigned long type);
	#if defined(__FreeBSD__)
	#define AT_HWCAP 25 /* CPU feature flags. */
	#define AT_HWCAP2 26 /* CPU feature flags 2. */
	extern int elf_aux_info(int aux, void *buf, int buflen);
	static unsigned long getauxval(unsigned long key)

Describe how to reproduce the problem

Try to compile for PowerPC on FreeBSD

Include any warning/errors/backtraces from the system logs

In file included from /usr/src/sys/contrib/openzfs/module/icp/algs/aes/aes_impl.c:28:
/usr/src/sys/contrib/openzfs/lib/libspl/include/sys/simd.h:461:22: error: static declaration of 'getauxval' follows non-static declaration
static unsigned long getauxval(unsigned long key)
                     ^
/usr/src/sys/contrib/openzfs/lib/libspl/include/sys/simd.h:456:22: note: previous declaration is here
extern unsigned long getauxval(unsigned long type);
                     ^

[mmatuska]

@mcmilk please verify

[mcmilk]

@mcmilk please verify

I am sorry for this. The declaration of extern unsigned long getauxval(unsigned long type) belongs to the linux section.
I created a PR for fixing this: #13936 - could you test this please.

[mmatuska]

@mcmilk thanks, but we need more:

in include/os/freebsd/spl/sys/simd_powerpc.h:

1. there is no <powerpc/cpu.h>, you want <machine/cpu.h>
   or does the build system provide otherwise? In FreeBSD base we need <machine/cpu.h>
2. you are missing an #endif at the end of the file

zfs/include/os/freebsd/spl/sys/simd_powerpc.h

Lines 49 to 90 in c629f0b

	#ifndef _FREEBSD_SIMD_POWERPC_H
	#define _FREEBSD_SIMD_POWERPC_H
	#include <sys/types.h>
	#include <sys/cdefs.h>
	#include <machine/pcb.h>
	#include <powerpc/cpu.h>
	#define kfpu_allowed() 1
	#define kfpu_initialize(tsk) do {} while (0)
	#define kfpu_begin() do {} while (0)
	#define kfpu_end() do {} while (0)
	#define kfpu_init() (0)
	#define kfpu_fini() do {} while (0)
	/*
	* Check if Altivec is available
	*/
	static inline boolean_t
	zfs_altivec_available(void)
	{
	return ((cpu_features & PPC_FEATURE_HAS_ALTIVEC) != 0);
	}
	/*
	* Check if VSX is available
	*/
	static inline boolean_t
	zfs_vsx_available(void)
	{
	return ((cpu_features & PPC_FEATURE_HAS_VSX) != 0);
	}
	/*
	* Check if POWER ISA 2.07 is available (SHA2)
	*/
	static inline boolean_t
	zfs_isa207_available(void)
	{
	return ((cpu_features2 & PPC_FEATURE2_ARCH_2_07) != 0);
	}