Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errata #4 warning has a very long line due to a missing newline #8712

Closed
siebenmann opened this issue May 5, 2019 · 3 comments · Fixed by #8721
Closed

Errata #4 warning has a very long line due to a missing newline #8712

siebenmann opened this issue May 5, 2019 · 3 comments · Fixed by #8721
Milestone

Comments

@siebenmann
Copy link
Contributor

System information

Type Version/Name
Distribution Name Fedora
Distribution Version 29
Linux Kernel 5.0.10-200.fc29.x86_64
Architecture x86_64
ZFS Version 0.8.0-rc4_35_gde3e0b914
SPL Version 0.8.0-rc4_35_gde3e0b914

Describe the problem you're observing

After commit b3b6098, the warning message about Errata #4 has a very long line due to a missing newline at the end of the first part of the message in ``status_callback()''.

Describe how to reproduce the problem

$ zpool status
  pool: ssddata
 state: ONLINE
status: Errata #4 detected.
Existing encrypted snapshots and bookmarks contain an on-disk incompatibility.
        This may cause on-disk corruption if they are used with 'zfs recv'. action:  To correct the issue, enable the bookmark_v2 feature. No additional
        action is needed if there are no encrypted snapshots or bookmarks. If preserving
        the encrypted snapshots and bookmarks is required, use a non-raw send to backup
        and restore them. Alternately, they may be removed to resolve the
        incompatibility.
   see: http://zfsonlinux.org/msg/ZFS-8000-ER

In addition a few other lines in the action: portion of the message are longer than 80 characters when printed out.

@behlendorf behlendorf added this to the 0.8.0 milestone May 5, 2019
@rlaager
Copy link
Member

rlaager commented May 6, 2019

@JMoVS Any chance you could whip up a quick PR to fix this?

@rlaager
Copy link
Member

rlaager commented May 6, 2019

Based on that output, is the first line also missing a tab?

@JMoVS
Copy link
Contributor

JMoVS commented May 6, 2019

Apparently it is. I can whip up a PR and probably have it ready in ~ 16 hours, first have to sleep. May get there sooner. Sry for the trouble, I‘ll check

JMoVS added a commit to JMoVS/zol that referenced this issue May 7, 2019
fixes openzfs#8712

Signed-off-by: Justin Scholz <git@justinscholz.de>
JMoVS added a commit to JMoVS/zol that referenced this issue May 7, 2019
fixes openzfs#8712

Signed-off-by: Justin Scholz <git@justinscholz.de>
@JMoVS JMoVS mentioned this issue May 7, 2019
12 tasks
behlendorf pushed a commit to behlendorf/zfs that referenced this issue May 7, 2019
Signed-off-by: Justin Scholz <git@justinscholz.de>
Issue openzfs#8712
behlendorf pushed a commit to behlendorf/zfs that referenced this issue May 7, 2019
Signed-off-by: Justin Scholz <git@justinscholz.de>
Issue openzfs#8712
behlendorf pushed a commit that referenced this issue May 8, 2019
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Justin Scholz <git@justinscholz.de>
Closes #8712 
Closes #8721
allanjude pushed a commit to allanjude/zfs that referenced this issue Jun 7, 2019
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Justin Scholz <git@justinscholz.de>
Closes openzfs#8712 
Closes openzfs#8721
allanjude pushed a commit to allanjude/zfs that referenced this issue Jun 15, 2019
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Justin Scholz <git@justinscholz.de>
Closes openzfs#8712 
Closes openzfs#8721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants