Consolidate arc_buf allocation checks #10057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmacy
force-pushed
the
projects/dbuf_alloc_arcbuf
branch
from
cc4a45d
to
9df4140
Compare
Codecov Report
@@ Coverage Diff @@
## master #10057 +/- ##
========================================
+ Coverage 79% 79% +<1%
========================================
Files 386 386
Lines 122318 122304 -14
========================================
+ Hits 96898 96980 +82
+ Misses 25420 25324 -96
Continue to review full report at Codecov.
|
behlendorf
reviewed
Feb 27, 2020
The following check currently occurs in three
separate locations in dbuf.c. This change
consolidates those checks in to dbuf_alloc_arcbuf
if (arc_is_encrypted(data)) {
...
} else if (compress_type != ZIO_COMPRESS_OFF) {
...
} else {
...
}
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
mattmacy
force-pushed
the
projects/dbuf_alloc_arcbuf
branch
from
9df4140
to
8817726
Compare
behlendorf
approved these changes
Feb 27, 2020
behlendorf
added
Status: Accepted
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The following check currently occurs in three separate locations
in dbuf.c. This change consolidates those checks in to the
dbuf_alloc_arcbuf_from_arcbuf() function.
if (arc_is_encrypted(data)) {
...
} else if (compress_type != ZIO_COMPRESS_OFF) {
...
} else {
...
}
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#10057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following check currently occurs in three
separate locations in dbuf.c. This change
consolidates those checks in to dbuf_alloc_arcbuf
if (arc_is_encrypted(data)) {
...
} else if (compress_type != ZIO_COMPRESS_OFF) {
...
} else {
...
}
Signed-off-by: Matt Macy mmacy@FreeBSD.org
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.