Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: Test boundary conditions in alloc_class_012 #10116

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2020

Motivation and Context

Issue #9142 describes an error in the checks for device removal that
can prevent removal of special allocation class vdevs in some
situations.

Description

Enhance alloc_class/alloc_class_012_pos to check situations where this
bug occurs.

Update zts-report with knowledge of issue #9142.

Also fixed a bug in the test on FreeBSD, using an incorrect flag for stat. Used get_objnum from libtest instead.

How Has This Been Tested?

Ran ZTS for -T alloc_class on FreeBSD.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

Issue openzfs#9142 describes an error in the checks for device removal that
can prevent removal of special allocation class vdevs in some
situations.

Enhance alloc_class/alloc_class_012_pos to check situations where this
bug occurs.

Update zts-report with knowledge of issue openzfs#9142.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Mar 10, 2020
@behlendorf behlendorf requested a review from amotin March 11, 2020 00:13
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sensible to me as a short term way to mitigate the disruptive ZTS failures. Has anyone looked in to how involved resolving the underlying removal issue would be? That would really be preferable.

@ghost
Copy link
Author

ghost commented Mar 11, 2020

I am under the impression that @amotin is looking at how to solve the issue and will create a PR when ready, at which point the tests should start passing and the exceptions can be removed from zts-report.

This PR was prompted by the discussion about the issue between @amotin and @don-brady on Slack.

@don-brady wrote:

There is a ZTS case for this in alloc_class_012_pos.ksh. Does this test pass on FreeBSD? if so and you have a case that fails maybe we can tweak the test to catch the failure?

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, sounds good.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 11, 2020
@behlendorf behlendorf merged commit cdbc34f into openzfs:master Mar 12, 2020
@ghost ghost deleted the zts-alloc_class-9142 branch March 12, 2020 18:44
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Issue openzfs#9142 describes an error in the checks for device removal that
can prevent removal of special allocation class vdevs in some
situations.

Enhance alloc_class/alloc_class_012_pos to check situations where this
bug occurs.

Update zts-report with knowledge of issue openzfs#9142.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#10116 
Issue openzfs#9142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant