Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore zfs_arc_max below allmem/32 #10158

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Don't ignore zfs_arc_max below allmem/32 #10158

merged 1 commit into from
Apr 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2020 •
edited by ghost
Loading

Motivation and Context

Fixes #10157

Description

Set arc_c_min before arc_c_max so that when zfs_arc_min is set lower
than the default allmem/32 zfs_arc_max can also be set lower.

Add warning messages when tunables are being ignored.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@ghost
Copy link
Author

ghost commented Mar 26, 2020

@eric1894 can you see if this fixes your issue?

@ghost ghost added the Status: Code Review Needed Ready for review and testing label Mar 27, 2020
@ghost ghost marked this pull request as ready for review March 27, 2020 03:35
@codecov-io
Copy link

codecov-io commented Mar 27, 2020 •
edited
Loading

Codecov Report

Merging #10158 into master will decrease coverage by 13.30%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #10158       +/-   ##
===========================================
- Coverage   78.98%   65.68%   -13.31%     
===========================================
  Files         385      304       -81     
  Lines      122594   105325    -17269     
===========================================
- Hits        96831    69181    -27650     
- Misses      25763    36144    +10381
Flag Coverage Δ
#kernel ?
#user 65.68% <73.33%> (+0.74%) ⬆️
Impacted Files Coverage Δ
module/os/linux/zfs/arc_os.c 40.00% <ø> (-19.68%) ⬇️
module/zfs/arc.c 75.68% <73.33%> (-6.11%) ⬇️
module/zfs/objlist.c 0.00% <0.00%> (-100.00%) ⬇️
module/zfs/pathname.c 0.00% <0.00%> (-100.00%) ⬇️
include/sys/dmu_redact.h 0.00% <0.00%> (-100.00%) ⬇️
include/sys/dmu_traverse.h 0.00% <0.00%> (-100.00%) ⬇️
module/zcommon/zfs_fletcher_superscalar4.c 1.56% <0.00%> (-96.88%) ⬇️
module/zfs/zfs_rlock.c 0.00% <0.00%> (-96.36%) ⬇️
module/lua/ltablib.c 2.34% <0.00%> (-95.32%) ⬇️
module/zfs/bqueue.c 0.00% <0.00%> (-94.45%) ⬇️
... and 241 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a42ef0...1b109bd. Read the comment docs.

@ghost ghost force-pushed the openzfs-10157 branch 2 times, most recently from b46c7d2 to 376b2fc Compare March 31, 2020 20:17
@ghost
Copy link
Author

ghost commented Mar 31, 2020

  • Add a parameter to arc_tuning_update() to control logging of warnings in non-debug builds

@ghost ghost requested a review from behlendorf April 3, 2020 16:58
behlendorf
behlendorf approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the cstyle issue, looks good.

module/zfs/arc.c Outdated Show resolved Hide resolved
Don't ignore zfs_arc_max below allmem/32
1b109bd 
Fixes openzfs#10157

Set arc_c_min before arc_c_max so that when zfs_arc_min is set lower
than the default allmem/32 zfs_arc_max can also be set lower.

Add warning messages when tunables are being ignored.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 9, 2020
@behlendorf behlendorf merged commit 36a6e23 into openzfs:master Apr 9, 2020
@ghost ghost deleted the openzfs-10157 branch April 9, 2020 22:40
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@jsai20
Don't ignore zfs_arc_max below allmem/32
e961335 
Set arc_c_min before arc_c_max so that when zfs_arc_min is set lower
than the default allmem/32 zfs_arc_max can also be set lower.

Add warning messages when tunables are being ignored.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#10157
Closes openzfs#10158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zfs_arc_max init option silently ignored if value is less than default arc_c_min
4 participants
@codecov-io @behlendorf @eric1894 @ceedriic