[WIP] zfs_create: round up volume size to multiple of bs #10196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10196 +/- ##
==========================================
- Coverage 79.33% 79.17% -0.17%
==========================================
Files 389 389
Lines 123038 123046 +8
==========================================
- Hits 97611 97419 -192
- Misses 25427 25627 +200
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Apr 23, 2020
tests/zfs-tests/tests/functional/cli_root/zfs_create/zfs_create_002_pos.ksh
Outdated
Show resolved
Hide resolved
Round up the volume size requested in `zfs create -V size` to the next higher multiple of the volblocksize. Updates the man page and adds a test to verify the new behavior. Reported-by: puffi <puffi@users.noreply.github.com> Signed-off-by: Alex John <alex@stty.io>
behlendorf
added
Status: Accepted
as-com
pushed a commit
to as-com/zfs
that referenced
this pull request
Jun 20, 2020
Round up the volume size requested in `zfs create -V size` to the next higher multiple of the volblocksize. Updates the man page and adds a test to verify the new behavior. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reported-by: puffi <puffi@users.noreply.github.com> Signed-off-by: Alex John <alex@stty.io> Closes openzfs#8541 Closes openzfs#10196 (cherry picked from commit 47c9299)
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Round up the volume size requested in `zfs create -V size` to the next higher multiple of the volblocksize. Updates the man page and adds a test to verify the new behavior. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reported-by: puffi <puffi@users.noreply.github.com> Signed-off-by: Alex John <alex@stty.io> Closes openzfs#8541 Closes openzfs#10196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round up the volume size requested in
zfs create -V sizeto the nexthigher multiple of the volblocksize. Updates the man page and adds a
test to verify the new behavior.
Reported-by: puffi puffi@users.noreply.github.com
Signed-off-by: Alex John alex@stty.io
Motivation and Context
Fixes #8541
Description
Adds a check in zfs_main after all the arguments have been parsed to check if its a volume. Then we check if the user has specified a blocksize, if not, set it to default and check if the volsize is a multiple of. If not, round it up using the
P2ROUNDUP_TYPEDmacro and set the new volsize in the nvlist.Documentation has been updated to reflect the above and a naive test added (which can be improved).
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.