Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new FreeBSD API to largely eliminate object locking #10205

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

mattmacy
Copy link
Contributor

Propagate changes in HEAD that mostly eliminate object locking.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@mattmacy mattmacy force-pushed the projects/vm_object_locking branch 3 times, most recently from 7286c22 to fad5d06 Compare April 14, 2020 23:01
@adamdmoss
Copy link
Contributor

A note for readers: this relates entirely to FreeBSD. That wasn't obvious to me from the description or title so I thought I'd point it out. :)

@ahrens ahrens changed the title use new API to largely eliminate object locking use new FreeBSD API to largely eliminate object locking Apr 15, 2020
@codecov-io
Copy link

codecov-io commented Apr 15, 2020

Codecov Report

Merging #10205 into master will decrease coverage by 13.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #10205       +/-   ##
===========================================
- Coverage   79.38%   65.77%   -13.62%     
===========================================
  Files         388      306       -82     
  Lines      123392   106102    -17290     
===========================================
- Hits        97953    69785    -28168     
- Misses      25439    36317    +10878     
Flag Coverage Δ
#kernel ?
#user 65.77% <ø> (+0.26%) ⬆️
Impacted Files Coverage Δ
module/zfs/objlist.c 0.00% <0.00%> (-100.00%) ⬇️
module/zfs/pathname.c 0.00% <0.00%> (-100.00%) ⬇️
include/sys/dmu_redact.h 0.00% <0.00%> (-100.00%) ⬇️
include/sys/dmu_traverse.h 0.00% <0.00%> (-100.00%) ⬇️
module/zfs/zfs_rlock.c 0.00% <0.00%> (-96.36%) ⬇️
module/lua/ltablib.c 2.34% <0.00%> (-95.32%) ⬇️
module/zfs/bqueue.c 0.00% <0.00%> (-94.45%) ⬇️
module/zcommon/zfs_deleg.c 0.00% <0.00%> (-92.46%) ⬇️
module/zfs/dmu_diff.c 0.00% <0.00%> (-87.88%) ⬇️
module/zfs/zcp_set.c 0.00% <0.00%> (-87.10%) ⬇️
... and 236 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7929f3...cc80dfc. Read the comment docs.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 15, 2020
@behlendorf behlendorf requested review from a user and amotin April 15, 2020 18:09
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
@behlendorf behlendorf merged commit c614fd6 into openzfs:master Apr 17, 2020
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 17, 2020
@mattmacy mattmacy deleted the projects/vm_object_locking branch June 10, 2020 05:02
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Propagate changes in HEAD that mostly eliminate object locking.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#10205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants