Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persistent L2ARC minor fixes #10210

Merged
merged 1 commit into from
Apr 17, 2020
Merged

persistent L2ARC minor fixes #10210

merged 1 commit into from
Apr 17, 2020

Conversation

gamanakis
Copy link
Contributor

Minor fixes on persistent L2ARC improving code readability and fixing a typo in zdb.c when byte-swapping a log block. It also improves the pesist_l2arc_007_pos.ksh test by giving it more time to retrieve log blocks on the cache device.

Signed-off-by: George Amanakis gamanakis@gmail.com

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@gamanakis
persistent L2ARC minor fixes
fab91ae 
Signed-off-by: George Amanakis <gamanakis@gmail.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 15, 2020
adamdmoss
adamdmoss approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@adamdmoss adamdmoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit, but reviewed and approved. :)

module/zfs/arc.c Show resolved Hide resolved
adamdmoss
adamdmoss approved these changes Apr 16, 2020
View reviewed changes
cmd/zdb/zdb.c Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #10210 into master will decrease coverage by 13.75%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #10210       +/-   ##
===========================================
- Coverage   79.23%   65.47%   -13.76%     
===========================================
  Files         388      306       -82     
  Lines      123392   106100    -17292     
===========================================
- Hits        97768    69470    -28298     
- Misses      25624    36630    +11006
Flag Coverage Δ
#kernel ?
#user 65.47% <0.00%> (+0.21%) ⬆️
Impacted Files Coverage Δ
cmd/zdb/zdb.c 80.27% <0.00%> (-0.28%) ⬇️
module/zfs/arc.c 71.59% <0.00%> (-14.36%) ⬇️
module/zfs/objlist.c 0.00% <0.00%> (-100.00%) ⬇️
module/zfs/pathname.c 0.00% <0.00%> (-100.00%) ⬇️
include/sys/dmu_redact.h 0.00% <0.00%> (-100.00%) ⬇️
include/sys/dmu_traverse.h 0.00% <0.00%> (-100.00%) ⬇️
module/zfs/zfs_rlock.c 0.00% <0.00%> (-96.36%) ⬇️
module/lua/ltablib.c 2.34% <0.00%> (-95.32%) ⬇️
module/zfs/bqueue.c 0.00% <0.00%> (-94.45%) ⬇️
module/zcommon/zfs_deleg.c 0.00% <0.00%> (-92.46%) ⬇️
... and 241 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af99094...fab91ae. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 16, 2020
@behlendorf behlendorf merged commit 9249f12 into openzfs:master Apr 17, 2020
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@gamanakis @jsai20
Persistent L2ARC minor fixes
757b9fa 
Minor fixes on persistent L2ARC improving code readability and fixing 
a typo in zdb.c when byte-swapping a log block. It also improves the 
pesist_l2arc_007_pos.ksh test by giving it more time to retrieve log 
blocks on the cache device.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Adam D. Moss <c@yotes.com>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#10210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdmoss adamdmoss adamdmoss approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gamanakis @codecov-io @behlendorf @adamdmoss