remove deduplicated send/receive code #10212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deduplicated send streams (i.e. `zfs send -D` and `zfs receive` of such streams) are deprecated. Deduplicated send streams can be received by first converting them to non-deduplicated with the `zstream redup` command. This commit removes the code for sending and receiving deduplicated send streams. `zfs send -D` will now print a warning, ignore the `-D` flag, and generate a regular (non-deduplicated) send stream. `zfs receive` of a deduplicated send stream will print an error message and fail. The resulting code simplification (especially in the kernel's support for receiving dedup streams) should help enable future performance enhancements. Several new tests are added which leverage `zstream redup`. Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
ahrens
added
Component: Send/Recv
Codecov Report
@@ Coverage Diff @@
## master #10212 +/- ##
===========================================
- Coverage 79.38% 65.80% -13.58%
===========================================
Files 388 306 -82
Lines 123392 105776 -17616
===========================================
- Hits 97953 69611 -28342
- Misses 25439 36165 +10726
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Apr 20, 2020
pcd1193182
approved these changes
Apr 21, 2020
| "deprecated, and will be removed in a\n" | ||
| "future release. (In the future, the flag will be " | ||
| "accepted, but a\n" | ||
| "regular, non-deduplicated stream will be " |
There was a problem hiding this comment.
Is this actually going into a separate release from the previous patch? If not, we might be rolling forwards with this a bit too quickly
There was a problem hiding this comment.
Yes, the previous commit which added this message is being backported to 0.8.4, but this commit won't be backported, it will be released with 2.0.
behlendorf
added
Status: Accepted
This was referenced Apr 28, 2020
as-com
pushed a commit
to as-com/zfs
that referenced
this pull request
Jun 20, 2020
Deduplicated send streams (i.e. `zfs send -D` and `zfs receive` of such streams) are deprecated. Deduplicated send streams can be received by first converting them to non-deduplicated with the `zstream redup` command. This commit removes the code for sending and receiving deduplicated send streams. `zfs send -D` will now print a warning, ignore the `-D` flag, and generate a regular (non-deduplicated) send stream. `zfs receive` of a deduplicated send stream will print an error message and fail. The resulting code simplification (especially in the kernel's support for receiving dedup streams) should help enable future performance enhancements. Several new tests are added which leverage `zstream redup`. Reviewed-by: Paul Dagnelie <pcd@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> Issue openzfs#7887 Issue openzfs#10117 Issue openzfs#10156 Closes openzfs#10212 (cherry picked from commit 196bee4)
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Deduplicated send streams (i.e. `zfs send -D` and `zfs receive` of such streams) are deprecated. Deduplicated send streams can be received by first converting them to non-deduplicated with the `zstream redup` command. This commit removes the code for sending and receiving deduplicated send streams. `zfs send -D` will now print a warning, ignore the `-D` flag, and generate a regular (non-deduplicated) send stream. `zfs receive` of a deduplicated send stream will print an error message and fail. The resulting code simplification (especially in the kernel's support for receiving dedup streams) should help enable future performance enhancements. Several new tests are added which leverage `zstream redup`. Reviewed-by: Paul Dagnelie <pcd@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> Issue openzfs#7887 Issue openzfs#10117 Issue openzfs#10156 Closes openzfs#10212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Deduplicated send streams (i.e.
zfs send -Dandzfs receiveof suchstreams) are deprecated. Deduplicated send streams can be received by
first converting them to non-deduplicated with the
zstream redupcommand.
See #10117, #10156, and #7887
Description
This commit removes the code for sending and receiving deduplicated send
streams.
zfs send -Dwill now print a warning, ignore the-Dflag,and generate a regular (non-deduplicated) send stream.
zfs receiveofa deduplicated send stream will print an error message and fail.
The resulting code simplification (especially in the kernel's support
for receiving dedup streams) should help enable future performance
enhancements.
How Has This Been Tested?
Several new tests are added which leverage
zstream redup.Types of changes
Checklist:
Signed-off-by.