Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change libspl list member names to match kernel #10236

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Conversation

ahrens
Copy link
Member

@ahrens ahrens commented Apr 21, 2020

Motivation and Context

This aids in debugging, so that we can use the same infrastructure to
walk zfs's list_t in the kernel module and in the userland libraries
(e.g. when debugging ztest).

Description

change list_node member names.

How Has This Been Tested?

compile and run ztest.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

This aids in debugging, so that we can use the same infrastructure to
walk zfs's list_t in the kernel module and in the userland libraries
(e.g. when debugging ztest).

Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
@ahrens ahrens added the Status: Code Review Needed Ready for review and testing label Apr 21, 2020
ahrens added a commit to ahrens/sdb that referenced this pull request Apr 21, 2020
As we know, drgn type equality does not work right, so we need to
compare canonicalized type names.

When combined with openzfs/zfs#10236,
`zfs_dbgmsg` now works on ztest core dumps.
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 23, 2020
@behlendorf behlendorf merged commit 5d4ed96 into openzfs:master Apr 23, 2020
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
This aids in debugging, so that we can use the same infrastructure to
walk zfs's list_t in the kernel module and in the userland libraries
(e.g. when debugging ztest).

Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes openzfs#10236 
(cherry picked from commit 5d4ed96)
sdimitro pushed a commit to sdimitro/sdb-dlpx that referenced this pull request Sep 25, 2020
As we know, drgn type equality does not work right, so we need to
compare canonicalized type names. When combined with openzfs/zfs#10236,
`zfs_dbgmsg` now works on ztest core dumps.

Serapheim Note:
With drgn changing its type rules once again this commit is now needed
for existing tests to not fail.
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
This aids in debugging, so that we can use the same infrastructure to
walk zfs's list_t in the kernel module and in the userland libraries
(e.g. when debugging ztest).

Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes openzfs#10236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants