Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Count CKSUM for all vdevs in verify_pool #10271

Merged
merged 1 commit into from
May 1, 2020
Merged

ZTS: Count CKSUM for all vdevs in verify_pool #10271

merged 1 commit into from
May 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2020

Motivation and Context

The verify_pool function should detect checksum errors on any vdev, but
it was only checking at the root of the pool.

Description

Accumulate the errors for all vdevs to obtain the correct count.

How Has This Been Tested?

Manually checked on a pool zinjected with checksum errors.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

ZTS: Count CKSUM for all vdevs in verify_pool
8b42f24 
The verify_pool function should detect checksum errors on any vdev, but
it was only checking at the root of the pool.

Accumulate the errors for all vdevs to obtain the correct count.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Apr 30, 2020
@ghost ghost requested a review from behlendorf April 30, 2020 00:02
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 1, 2020
@behlendorf behlendorf merged commit 6ed4391 into openzfs:master May 1, 2020
@ghost ghost deleted the zts-verify_pool-awk branch May 1, 2020 03:58
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
@as-com
ZTS: Count CKSUM for all vdevs in verify_pool
a4a2fdd 
The verify_pool function should detect checksum errors on any vdev, but
it was only checking at the root of the pool.

Accumulate the errors for all vdevs to obtain the correct count.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#10271 
(cherry picked from commit 6ed4391)
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@jsai20
ZTS: Count CKSUM for all vdevs in verify_pool
ffeff2a 
The verify_pool function should detect checksum errors on any vdev, but
it was only checking at the root of the pool.

Accumulate the errors for all vdevs to obtain the correct count.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#10271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @jwk404